Page 1 of 1

Favicon location

Posted: Fri Sep 04, 2015 12:28 am
by AlexTG
On Opera browser the facicon's not showing on all pages. I was looking at the unilang github and they have a commit with the description "moved favicon to right place", which puts the favicon in the root phpbb directory. When I do that on my local phpbb copy it works like a charm, I get the favicon everywhere. I know we're supposed to do pull requests for our changes but it's such a small change it'd probably be easier for EMK to just do it directly right?

The favicon is currently accessible at "http://forum.language-learners.org/images/favicon.ico", which is separate from the github repo.

Re: Favicon location

Posted: Fri Sep 04, 2015 7:44 am
by rdearman
AlexTG wrote:On Opera browser the facicon's not showing on all pages. I was looking at the unilang github and they have a commit with the description "moved favicon to right place", which puts the favicon in the root phpbb directory. When I do that on my local phpbb copy it works like a charm, I get the favicon everywhere. I know we're supposed to do pull requests for our changes but it's such a small change it'd probably be easier for EMK to just do it directly right?

The favicon is currently accessible at "http://forum.language-learners.org/images/favicon.ico", which is separate from the github repo.

I copied it to both locations, rather than move it. Hopefully that fixes the problem.

Re: Favicon location

Posted: Fri Sep 04, 2015 7:53 am
by AlexTG
Yep that did it, thanks!