On Opera browser the facicon's not showing on all pages. I was looking at the unilang github and they have a commit with the description "moved favicon to right place", which puts the favicon in the root phpbb directory. When I do that on my local phpbb copy it works like a charm, I get the favicon everywhere. I know we're supposed to do pull requests for our changes but it's such a small change it'd probably be easier for EMK to just do it directly right?
The favicon is currently accessible at "http://forum.language-learners.org/images/favicon.ico", which is separate from the github repo.
Favicon location
-
AlexTG
- Green Belt
- Posts: 299
- Joined: Sat Jul 18, 2015 12:14 pm
- Location: Tasmania, Australia
- Languages: Easy to Read: English(N), French, Spanish
Able to Read: German, Latin
Learning to Read: Japanese, Hindi/Urdu - x 528
Favicon location
0 x
-
rdearman
- Site Admin
- Posts: 5464
- Joined: Thu May 14, 2015 4:18 pm
- Location: United Kingdom
- Languages: English (N)
- Language Log: viewtopic.php?f=15&t=1836
- x 14201
- Contact:
Re: Favicon location
AlexTG wrote:On Opera browser the facicon's not showing on all pages. I was looking at the unilang github and they have a commit with the description "moved favicon to right place", which puts the favicon in the root phpbb directory. When I do that on my local phpbb copy it works like a charm, I get the favicon everywhere. I know we're supposed to do pull requests for our changes but it's such a small change it'd probably be easier for EMK to just do it directly right?
The favicon is currently accessible at "http://forum.language-learners.org/images/favicon.ico", which is separate from the github repo.
I copied it to both locations, rather than move it. Hopefully that fixes the problem.
1 x
Anyone who thinks assembly language programming is difficult, obviously hasn't used Rust.
The Autodidactic Podcast
The Lollygagging Podcast
The Autodidactic Podcast
The Lollygagging Podcast
Who is online
Users browsing this forum: No registered users and 1 guest