Favicon location

Small area for language related software developers. If you have a feature request please put in the appropriate place. This area is for developers of language software and forum software development only.
User avatar
AlexTG
Green Belt
Posts: 298
Joined: Sat Jul 18, 2015 12:14 pm
Location: Tasmania, Australia
Languages: Strongest: English(N), French
Strongish: Spanish
Studying: Latin, Japanese, German
x 503

Favicon location

Postby AlexTG » Fri Sep 04, 2015 12:28 am

On Opera browser the facicon's not showing on all pages. I was looking at the unilang github and they have a commit with the description "moved favicon to right place", which puts the favicon in the root phpbb directory. When I do that on my local phpbb copy it works like a charm, I get the favicon everywhere. I know we're supposed to do pull requests for our changes but it's such a small change it'd probably be easier for EMK to just do it directly right?

The favicon is currently accessible at "http://forum.language-learners.org/images/favicon.ico", which is separate from the github repo.
0 x

Online
User avatar
rdearman
Site Admin
Posts: 2327
Joined: Thu May 14, 2015 4:18 pm
Location: United Kingdom
Languages: English (N)
French (studies), Italian (studies), Mandarin (studies),
Esperanto TAC (Only god knows why), Finnish (only in it for the cookies)
Language Log: viewtopic.php?f=15&t=1836
x 4682
Contact:

Re: Favicon location

Postby rdearman » Fri Sep 04, 2015 7:44 am

AlexTG wrote:On Opera browser the facicon's not showing on all pages. I was looking at the unilang github and they have a commit with the description "moved favicon to right place", which puts the favicon in the root phpbb directory. When I do that on my local phpbb copy it works like a charm, I get the favicon everywhere. I know we're supposed to do pull requests for our changes but it's such a small change it'd probably be easier for EMK to just do it directly right?

The favicon is currently accessible at "http://forum.language-learners.org/images/favicon.ico", which is separate from the github repo.

I copied it to both locations, rather than move it. Hopefully that fixes the problem.
1 x

User avatar
AlexTG
Green Belt
Posts: 298
Joined: Sat Jul 18, 2015 12:14 pm
Location: Tasmania, Australia
Languages: Strongest: English(N), French
Strongish: Spanish
Studying: Latin, Japanese, German
x 503

Re: Favicon location

Postby AlexTG » Fri Sep 04, 2015 7:53 am

Yep that did it, thanks!
0 x


Return to “Development Area”

Who is online

Users browsing this forum: No registered users and 1 guest