Notifications about Likes

[Brun Ugle]

Generally the names are shown when you hover over the number, not the heart

Oops. I remembered wrongly because I'm on my iPad, so I can't check.

[Allison]

Generally the names are shown when you hover over the number, not the heart

That works, thanks! I had been trying to hover over the heart with no success.

[emk]

I can confirm that some "likes" are still not showing up.

Eyeballing the code, it looks like this is where notifications get generated. They then pass through here, and then wind their way down into the main phpBB code. There's a chunk of code here which attempts to avoid sending duplicate notifications. Duplicates are detected using an "$item_id".

And when we look up item_id calculation, we find this very suspicious bit of code which sets the item ID to the "requester_id".

The fix here is probably to include both the requester ID (the person who clicked on the heart, I think) and the post ID when calculating the "$item_id", so that you could receive one notification per user per post. If I understand the current code correctly (which is far from certain), it looks as if you can maybe receive only one "like" per user. I'd imagine that if you can somehow clear your notifications, this would reset.

If any programmers reading this feel like they understand the issue well enough to submit a pull request to the postlove maintainer, I'd be happy to update the forum's copy of postlove. I might be able to tackle this myself at some point, but it's a bit hairy and I'd want to make sure I understood everything that used "$item_id".

As for disappearing "likes" in your notification history, check your profile page. There should be a link which shows all the "likes" you've given and received. Look at the lower right. This should also include "likes" for which you never received a notification, so it might be a short-term workaround for the other problem as well.

[Serpent]

I think it resets for me when I mark all as read, and/or it gets reset per user when I mark "their" notification as read I often use the notification links to go to threads, which also marks the notifications as read.

[tangleweeds]

Going to my notifications page and clicking to mark them all read seems to have fixed things/ Now I can even see who liked posts. Thanks!

[Evita]

As for disappearing "likes" in your notification history, check your profile page. There should be a link which shows all the "likes" you've given and received. Look at the lower right. This should also include "likes" for which you never received a notification, so it might be a short-term workaround for the other problem as well.

Sorry, I just don't see it. Am I blind? I received some notifications yesterday so I have 13 now, but the oldest one is still from December 10.

llattach.png

Edit: Never mind, I found the link you were talking about. But I'm talking about Notifications being deleted even though at the top it says "Here you may view all past notifications."