For developers: Forum source code on GitHub

Discuss technical problems and features here
t123
White Belt
Posts: 49
Joined: Sat Jul 18, 2015 1:48 pm
x 67

Re: For developers: Forum source code on GitHub

Postby t123 » Fri Aug 21, 2015 7:49 pm

I created an extension to add New posts and Active topics next to the FAQ at the top. Do I just send a pull request?
1 x

User avatar
emk
Black Belt - 1st Dan
Posts: 1622
Joined: Sat Jul 18, 2015 12:07 pm
Location: Vermont, USA
Languages: English (N), French (B2+)
Badly neglected "just for fun" languages: Middle Egyptian, Spanish.
Language Log: viewtopic.php?f=15&t=723
x 6334
Contact:

Re: For developers: Forum source code on GitHub

Postby emk » Fri Aug 21, 2015 7:52 pm

t123 wrote:I created an extension to add New posts and Active topics next to the FAQ at the top. Do I just send a pull request?

You rule. (As does zenmonkey.) That exact patch was on my TODO list. Please feel free to kick me a pull request.

Note that we may want to also look at how this interacts with the "we_universal" theme at some point. But we can do that later. :-)
0 x

t123
White Belt
Posts: 49
Joined: Sat Jul 18, 2015 1:48 pm
x 67

Re: For developers: Forum source code on GitHub

Postby t123 » Fri Aug 21, 2015 8:23 pm

Actually while I am it, I've been using the following style sheet to fix some of the layout issues:

Code: Select all

#wrap
{
    max-width: inherit;
}

#wrap .post {
    padding: 5px;
}

#wrap dl.postprofile
{
    width: 18%;
    margin: 0;
}

#wrap .postbody
{
    width: 81%;
    padding: 0 0 0 5px;
}

#wrap .postbody .content {
   
    font-family: Tahoma;font-size: 1.5em;
}

#wrap p.author
{
    font-size: 1.2em;
}
0 x

User avatar
emk
Black Belt - 1st Dan
Posts: 1622
Joined: Sat Jul 18, 2015 12:07 pm
Location: Vermont, USA
Languages: English (N), French (B2+)
Badly neglected "just for fun" languages: Middle Egyptian, Spanish.
Language Log: viewtopic.php?f=15&t=723
x 6334
Contact:

Re: For developers: Forum source code on GitHub

Postby emk » Fri Aug 21, 2015 8:55 pm

t123 wrote:Actually while I am it, I've been using the following style sheet to fix some of the layout issues:

We're very likely to switch the site over to the "we_universal" theme, because that's what everybody seemed to like in the recent thread. If you want to test out CSS tweaks, you may want to try them against that theme, and not the default. I hope this helps! And thank you once again for working on an extension; that's going to be a great starting point for other developers.
0 x

t123
White Belt
Posts: 49
Joined: Sat Jul 18, 2015 1:48 pm
x 67

Re: For developers: Forum source code on GitHub

Postby t123 » Fri Aug 21, 2015 9:04 pm

The CSS is just for anyone who wants a quick fix in their local browser via Stylish or something. It basically removes the annoying max width setting and increases the font size a bit.
0 x

Zireael
Orange Belt
Posts: 158
Joined: Mon Jul 20, 2015 6:29 pm
Languages: Native: Polish
C2: English
B2: Spanish
Somewhere I don't know: German
Beginner: Arabic, Polish Sign Language
Wanderlusting: Japanese, Russian
Language Log: viewtopic.php?t=815
x 77

Re: For developers: Forum source code on GitHub

Postby Zireael » Sat Aug 22, 2015 8:43 am

zenmonkey wrote:I also recommend installing GitHub Desktop if you are on the Mac. It makes seeing branches, etc a bit easier.

I've created a pull for German, Italian, Hebrew packs and Advanced BBCode. I'll stop for now and await the merge and install to assure I'm doing things "as should be".


I use SourceTree, which has a Mac version too, for all my git stuff. I like their interface and it's less prone to bugs than the GitHub software.
1 x

User avatar
Serpent
Black Belt - 3rd Dan
Posts: 3657
Joined: Sat Jul 18, 2015 10:54 am
Location: Moskova
Languages: heritage
Russian (native); Belarusian, Polish

fluent or close: Finnish (certified C1), English; Portuguese, Spanish, German, Italian
learning: Croatian+, Ukrainian; Romanian, Galician; Danish, Swedish; Estonian
exploring: Latin, Karelian, Catalan, Dutch, Czech, Latvian
x 5179
Contact:

Re: For developers: Forum source code on GitHub

Postby Serpent » Fri Sep 04, 2015 6:02 am

Um, I have a github account but I'm not really a programmer :lol: Is there a way for me to submit corrections to the Finnish interface? :)
0 x
LyricsTraining now has Finnish and Polish :)
Corrections welcome

User avatar
zenmonkey
Black Belt - 2nd Dan
Posts: 2528
Joined: Sun Jul 26, 2015 7:21 pm
Location: California, Germany and France
Languages: Spanish, English, French trilingual - German (B2/C1) on/off study: Persian, Hebrew, Tibetan, Setswana.
Some knowledge of Italian, Portuguese, Ladino, Yiddish ...
Want to tackle Tzotzil, Nahuatl
Language Log: viewtopic.php?f=15&t=859
x 7030
Contact:

Re: For developers: Forum source code on GitHub

Postby zenmonkey » Fri Sep 04, 2015 7:54 am

Serpent wrote:Um, I have a github account but I'm not really a programmer :lol: Is there a way for me to submit corrections to the Finnish interface? :)


Just send them to me and I'll do it in the files.

If you prefer to download and edit them because you feel you want to learn how to do so, follow the instructions on the project page. This make sense really only if you plan to do other development or edits later.
Last edited by zenmonkey on Mon Sep 07, 2015 4:47 pm, edited 1 time in total.
0 x
I am a leaf on the wind, watch how I soar

User avatar
emk
Black Belt - 1st Dan
Posts: 1622
Joined: Sat Jul 18, 2015 12:07 pm
Location: Vermont, USA
Languages: English (N), French (B2+)
Badly neglected "just for fun" languages: Middle Egyptian, Spanish.
Language Log: viewtopic.php?f=15&t=723
x 6334
Contact:

Re: For developers: Forum source code on GitHub

Postby emk » Mon Sep 07, 2015 3:28 pm

Hello! Just a heads up: I had to be offline for the last week because of a really busy week at work, which cut into both language learning time and also forum time in a pretty drastic way. Anyway, I'll be trying to get to the backlog of pull requests this coming week when I have time.
0 x


Return to “Technical Support and Feature Requests”

Who is online

Users browsing this forum: No registered users and 2 guests